Skip to content

Add basic IP rate limiting to shell endpoint

Robert May requested to merge ip-rate-limit-ssh into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Adds the ability to rate limit the internal/allowed endpoint by IP. This is in addition to the user-based rate limit.

Related https://gitlab.com/gitlab-org/gitlab/-/issues/343103

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

This is very difficult to test locally because of the IP address requirement and other rate limits in place.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Robert May

Merge request reports

Loading