Skip to content

Add E2E to verify Repository License Detection

John McDonnell requested to merge jmd-add-license-checking-e2e into master

Description of the test

We had an incident gitlab-com/gl-infra/production#5478 (closed) why porting FindLicense from Ruby to Go. gitaly#3078 (closed) / gitaly!3797 (merged)

The underlying issue was caused due to the Go library being able to detect a broader range of licenses than the Licensee gem in rails. When attempting to parse the 'unknown' license we errored out, and the project landing page became inaccessible.
The rails part of this issue has been resolved with !69878 (merged) while an updated proposal for the service side change in gitaly can be found gitaly#3782 (closed)

This test is being added to provide additional coverage in this area to help identify similar regressions in this area going forward.

https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/366842
https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/366843

Checklist

  • Confirm the test has a testcase: tag linking to an existing test case in the test case project.
  • Note if the test is intended to run in specific scenarios. If a scenario is new, add a link to the MR that adds the new scenario.
  • Follow the end-to-end tests style guide and best practices.
  • Use the appropriate RSpec metadata tag(s).
  • Most resources will be cleaned up via the general cleanup task. Check that is successful, or ensure resources are cleaned up in the test:
    • New resources have api_get_path and api_delete_path implemented if possible.
    • If any resource cannot be deleted in the general delete task, make sure it is ignored.
    • If any resource cannot be deleted in the general delete task, remove it in the test (e.g., in an after block).
  • Ensure that no transient bugs are hidden accidentally due to the usage of waits and reloads.
  • Verify the tags to ensure it runs on the desired test environments.
  • If this MR has a dependency on another MR, such as a GitLab QA MR, specify the order in which the MRs should be merged.
  • (If applicable) Create a follow-up issue to document the special setup necessary to run the test: ISSUE_LINK
  • If the test requires an admin's personal access token, ensure that the test passes on your local environment with and without the GITLAB_QA_ADMIN_ACCESS_TOKEN provided.
Edited by John McDonnell

Merge request reports

Loading