Refactor Members ActivateService
What does this MR do and why?
Issue: #361096 (closed)
This refactors the ::Members::ActivateService
by
- Using factory methods to initialize the service
- Use
update_all
instead of looping over each member - Make it clear that either an
invited
member, auser
or the wholegroup
gets activated.
This has the following advantages:
- The API is easier to use and less error prone. Before that you had to either pass
user
,member
oractivate_all: true
- We use an
update_all
instead of doing a looping over each Member - It's more clear what resource gets activates. Before this change, passing
member
did update all memberships of the given member's user.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Nicolas Dular