Skip to content

Serialize security dashboard setup params as strings

Mehmet Emin INAC requested to merge 357104_serialize_init_values_as_strings into master

What does this MR do and why?

We've recently introduced new dashboard setup arguments which will be used by the frontend application by Add security report ingestion information to da... (!91368 - merged). While building and testing the feature, I didn't pay close attention to how these data props look like in the page source therefore missed the following fact;

  • If we serialize these values as boolean true/false;
    • When the value is true then the attribute will exist like data-pipeline-has-errors
    • When the value is false then the attribute will not exist in the page source.
  • If we serialize these values as string 'true'/'false';
    • When the value is true then the attribute will exist like data-pipeline-has-errors="true"
    • When the value is false then the attribute will exist like data-pipeline-has-errors="false"

Since the currently established convention is the latter one, with this MR I am changing these values to be serialized as strings.

Since this is not a user-facing change yet, I don't think the changelog is necessary.

Related to Add security report ingestion information to da... (!91368 - merged)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports