Skip to content

Fix double scroll in labels dropdown on MR sidebar

Simon Knox requested to merge psimyn-master-patch-50196 into master

What does this MR do and why?

Limit the sidebar height css rule to not apply to every form in the sidebar

Before it made the inside of the labels dropdown the same height as the page. This could mean either double scrollbars if you had lots of labels, or lots of space at the bottom of the dropdown if you didn't have so many labels.

before also before after
Screen_Shot_2022-07-07_at_8.21.59_pm Screen_Shot_2022-07-07_at_8.21.43_pm Screen_Shot_2022-07-07_at_8.21.22_pm
  1. Enable the flag
    Feature.enable(:moved_mr_sidebar)
  2. Visit any MR page
  3. Click the Labels dropdown
  4. Check that dropdown inside is the correct height (i.e. not the height of the page)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Simon Knox

Merge request reports

Loading