Skip to content

Fix flaky legacy pipelines spec

Stan Hu requested to merge sh-fix-legacy-pipelines-flaky-spec into master

What does this MR do and why?

The test was failing frequently because the Ajax request to play the manual job was running after the wait_for_requests, so the backend state of the job remained at scheduled instead of pending.

To reduce the chance of this happening, click the pipeline status graph and look for a pending icon. Checking the state of the backend shouldn't be required, but we include it just in case.

Closes #367483 (closed)

How to set up and validate locally

Run this:

bundle exec rspec ./spec/features/projects/pipelines/legacy_pipelines_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports

Loading