Fixes container registry popover not displaying on all rows
requested to merge 362646-glpopover-component-not-displaying-in-all-rows-of-the-container-registry into master
What does this MR do and why?
GlPopover component is not displaying when hovering on the rows of the container registry image list.
The fix for time is applied in Fixes time in container registry partial cleanu... (!92243 - merged)
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
- On a project with container registry images and clean up policies enabled.
- Push images to project/group so that you can view a list of images with multiple tags.
docker pull alpine:latest docker tag alpine:latest 127.0.0.1:5000/gitlab-org/gitlab-test:latest docker push 127.0.0.1:5000/gitlab-org/gitlab-test:latest docker tag alpine:latest 127.0.0.1:5000/gitlab-org/gitlab-test:temporary docker push 127.0.0.1:5000/gitlab-org/gitlab-test:temporary docker tag alpine:latest 127.0.0.1:5000/gitlab-org/gitlab-org/alpine/hello-world/hello-world docker push 127.0.0.1:5000/gitlab-org/gitlab-org/alpine/hello-world/hello-world
- Alternatively, you can also return
true
from both the computed properties https://gitlab.com/gitlab-org/gitlab/-/blob/362646-glpopover-component-not-displaying-in-all-rows-of-the-container-registry/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/cleanup_status.vue#L53-58
- Alternatively, you can also return
- Hover on the information icon on any image with a number of tags that have been partially cleaned up.
- The popover component should appear over each entry in the list
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Fixes #362646 (closed)
Edited by Rahul Chanila