Skip to content

Fixes container registry popover not displaying on all rows

What does this MR do and why?

GlPopover component is not displaying when hovering on the rows of the container registry image list.

The fix for time is applied in Fixes time in container registry partial cleanu... (!92243 - merged)

Screenshots or screen recordings

Before After
Screen_Shot_2022-07-18_at_2.11.17_pm Screen_Shot_2022-07-18_at_2.10.36_pm

How to set up and validate locally

  1. Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
  2. On a project with container registry images and clean up policies enabled.
  3. Push images to project/group so that you can view a list of images with multiple tags.
      docker pull alpine:latest
      docker tag alpine:latest 127.0.0.1:5000/gitlab-org/gitlab-test:latest
      docker push 127.0.0.1:5000/gitlab-org/gitlab-test:latest
      docker tag alpine:latest 127.0.0.1:5000/gitlab-org/gitlab-test:temporary
      docker push 127.0.0.1:5000/gitlab-org/gitlab-test:temporary
      docker tag alpine:latest 127.0.0.1:5000/gitlab-org/gitlab-org/alpine/hello-world/hello-world
      docker push 127.0.0.1:5000/gitlab-org/gitlab-org/alpine/hello-world/hello-world
    1. Alternatively, you can also return true from both the computed properties https://gitlab.com/gitlab-org/gitlab/-/blob/362646-glpopover-component-not-displaying-in-all-rows-of-the-container-registry/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/cleanup_status.vue#L53-58
  4. Hover on the information icon on any image with a number of tags that have been partially cleaned up.
  5. The popover component should appear over each entry in the list

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Fixes #362646 (closed)

Edited by Rahul Chanila

Merge request reports

Loading