Skip to content

Add missing colors highlighting

Nataliia Radina requested to merge 365816-syntax-highlighting-improvement into master

What does this MR do and why?

Summary On some themes, the syntax highlighting seems pretty broken.

Take this file for instance: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/vulnerabilities/resolve_service.rb

Light and Monokai seem wrong, but for posterity I've included all the themes below.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

light before light after monokai before monokai after
Screenshot_2022-07-12_at_16.59.46 Screenshot_2022-07-12_at_16.55.18 Screenshot_2022-07-12_at_16.59.20 Screenshot_2022-07-12_at_16.55.57

How to set up and validate locally

  1. Create a file with the contents copied from https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/vulnerabilities/resolve_service.rb
  2. Go to user preferences
  3. Change theme to light
  4. Check resolve_service.rb
  5. Change theme to monokai
  6. Check resolve_service.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #365816 (closed)

Edited by Nataliia Radina

Merge request reports

Loading