Skip to content

Rewrite git config accesses with calls to gitaly

James Fargher requested to merge gitaly_full_path into master

What does this MR do and why?

#336749 (closed)

  • Update the gitaly gem so that we have access to the new RPC in gitaly.

  • Rewrites all direct config accesses (these are all for fetching gitlab.fullpath) and replaces them with RPCs.

    Soon we will be using the praefect database in tests and when this happens we will not be able to directly manipulate repositories in gitaly without praefects knowledge.

    There is still one direct access https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/bare_repository_import/repository.rb#L20 but in this case the repository is not in gitaly (otherwise it would not work in production).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by James Fargher

Merge request reports