Skip to content

Fix some usages of check_runner_upgrade_status

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR addresses 500 error when fetching runner list in admin pa... (#367829 - closed) which was introduced by Return suggested version along with recommendation (!92126 - merged). It fixes some usages of Gitlab::Ci::RunnerUpgradeCheck#check_runner_upgrade_status which were missed in the original MR.

In that MR, Gitlab::Ci::RunnerUpgradeCheck#check_runner_upgrade_status was changed so that it returns a tuple of { <status>: <version> } instead of simply <status>, but some usages were missed.

I will open a follow-up MR to add more integration tests to make sure something like this doesn't easily happen in the future.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports

Loading