Skip to content

Add integration tests for RunnerType.upgradeStatus

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR adds:

  • an integration test between the GraphQL RunnerType.upgradeStatus field and the Gitlab::Ci::RunnerUpgradeCheck class, to uncover situations like #367829 (closed) during development;
  • an integration test between Ci::Runners::ReconcileExistingRunnerVersionsService#execute and the Gitlab::Ci::RunnerUpgradeCheck class for good measure.

Part of #367836 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Running the new test without the changes in !92411 (merged):

    image

  2. Running the new test with the changes results in green tests.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports

Loading