Skip to content

Project authorizations refresh on changes to ProjectMember should pass through Sidekiq

Manoj M J requested to merge mmj-project-auth-refresh-for-project-member-inline into master

What does this MR do and why?

In preparation for https://gitlab.com/gitlab-org/gitlab/-/issues/363163, we need to make this change so that the project authorizations refresh always happens via Sidekiq.

If it continues to happen via the service, and when we introduce delay (ie, sleep()) when inserting/deleting batches of project_authorizations records, it is going to sleep on the Puma worker. We do not want that, if at all the process is gonna sleep, it should happen in Sidekiq only.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Manoj M J

Merge request reports