Fix incorrect gl- utility class
What does this MR do and why?
Fixes the flex direction class
- Replace
gl-flex-column
withgl-flex-direction-column
Screenshots or screen recordings
No visual changes, by default the column direction is applied, so this worked implicitly although the class used doesnt exist in https://unpkg.com/browse/@gitlab/ui@42.22.0/src/scss/utilities.scss
How to set up and validate locally
- Apply this patch
diff --git a/ee/spec/features/billings/billing_plans_spec.rb b/ee/spec/features/billings/billing_plans_spec.rb
index 7b2851f3159..dfa3f759cf7 100644
--- a/ee/spec/features/billings/billing_plans_spec.rb
+++ b/ee/spec/features/billings/billing_plans_spec.rb
@@ -118,6 +118,7 @@ def external_upgrade_url(namespace, plan)
it 'displays subscription table' do
expect(page).to have_selector('.js-subscription-table')
+ binding.pry
end
end
- Run the billing plans spec in a headless browser and play around with the responsive stylinh
CHROME_HEADLESS=0 bin/spring rspec ./ee/spec/features/billings/billing_plans_spec.rb:155
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Ezekiel Kigbo