Show deployment approval comments
What does this MR do and why?
The comment allows for users to read why a deployment has been approved.
Comments are displayed in order of approval, and also show the avatar of the user approving the deployment.
Changelog: added
Move deployment approval from popover to modal
Now that the comments are also being shown, there is too much content to put into a popover. Instead, we can move things to a modal to give it more space.
Changelog: changed
Screenshots or screen recordings
How to set up and validate locally
- add the following
.gitlab-ci.yml
to a project for some deployments:
stages:
- deploy
- stop
image: alpine:latest
deploy-prod:
stage: deploy
script:
- sleep 60
- echo "deploying prod"
environment:
name: production
deploy-staging:
stage: deploy
script:
- echo "deploying staging"
environment:
name: staging
url: https://example.com
when: manual
deploy-review:
stage: deploy
script:
- echo "Deploying review/$CI_COMMIT_REF_NAME"
environment:
name: review/$CI_COMMIT_REF_NAME
auto_stop_in: 1 week
only:
- branches
except:
- main
stop_review_app:
script: stop-review-app
stage: stop
environment:
name: review/$CI_COMMIT_REF_SLUG
action: stop
rules:
- if: $CI_MERGE_REQUEST_ID
when: manual
Run a pipeline to create the initial environments, then protect the staging
environment in Settings > CI/CD.
Run another pipeline, and check the environments page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
For #354508 (closed)