Skip to content

Add tag to test that requires SSHD

Craig Miskell requested to merge tag-ssh-qa-job into master

What does this MR do and why?

The ability to do IP-based allow-listing for SSH depends heavily on the deployment architecture. It does not work out of the box with the Cloud-Native-Hybrid deployment (one of the GET models, as used by Dedicated) due to the use of native ingress-nginx. It could be made to work with gitlab-sshd and the PROXY protocol, but that is non-trivial and not necessarily always the desired architecture.

This tag allows this test to be specifically excluded when testing deployed instances in such architectures (e.g. for Dedicated)

In particular I'm running into this in (surprise) Dedicated, when trying to run QA tests on our UAT environments. I'm currently working around it by providing a value for CI_JOB_NAME env var(review-qa-<something>) so it hits the 'except', because this instance is not running in CI and I have control of all the env vars directly. But that's a fragile hack.

I'm also only suggesting this as a possible solution; there may be other better ones, and I'm open to any suggestions.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Craig Miskell

Merge request reports