Skip to content

Add QA env var to select use of public IP API

Craig Miskell requested to merge qa-pub-ip-explicit into master

What does this MR do and why?

gitlab-qa can be run in places other than CI that need to use an API to find the public IP address; this adds the environment variable QA_USE_PUBLIC_IP_API to allow that behavior to be explicitly requested, rather than just implicitly by detecting that the runtime env is CI.

In particular I'm interested in running it for Dedicated, where the execution environment is kubernetes (not CI), and the only current alternative is to lie to it about the CI env var, otherwise it will pick up the internal IP address of the k8s pod, which is particularly unhelpful for allow-list tests.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports