Skip to content

Update jsdom dependency

Lukas Eipert requested to merge leipert-update-jsdom into master

What does this MR do and why?

Update jsdom dependency

This fixes a vulnerability and also updates loads of sub dependencies. Raising it in a separate MR in case this creates new errors in jest.

Fix relativePathToAbsolute behavior with multiple slashes

It seems like the update to JSDOM changed URL behaviors in tests, they now seem to match what Firefox and Chrome produce.

This updates our relativePathToAbsolute util to remove multiple consecutive forward slashes, like we expected it to.

Update Markdown Serializer Spec Expectation

This is for handling the edge case of a markdown link ending with a closing angular bracket like: https://www.gitlab.com>

Before the test asserted that it equals https://www.gitlab.com>, while the markdown serializer actually serializes it to [https://www.gitlab.com>](https://www.gitlab.com%3E). This behavior (which arguably seems to be correct) was confirmed in Firefox.

Seems like something underlying in JSDOMs URL implementation fixed this.

Screenshots or screen recordings

N/A

How to set up and validate locally

If jest CI passes, we should be good.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports