Skip to content

Update design of security approvals in mr approval settings

Annabel Dunstone Gray requested to merge approval-policy into master

What does this MR do and why?

To help align the overall look with regular MR approvals:

  • Removes the slide down animation
  • Puts policy details into a well to help differentiate the policy name and the details
  • Right aligns the View details button to keep all actions right-aligned
  • Aligns Create security policy button on the left with the other table content
  • Switches the View details chevron toggle icons

Screenshots or screen recordings

Before After
Screen_Shot_2022-07-26_at_2.18.28_PM Screen_Shot_2022-07-26_at_2.12.08_PM
Screen_Shot_2022-07-26_at_2.18.12_PM Screen_Shot_2022-07-26_at_2.12.36_PM

How to set up and validate locally

  1. Navigate to project settings
  2. Expand Merge request approvals
  3. Click Create a security policy (and go through entire policy/policy project creation setup)
  4. Once the policy has been created, go back to Merge request approvals in your original project
  5. Expand your newly created security project

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Annabel Dunstone Gray

Merge request reports

Loading