Skip to content

Remove embed_sign, it has been deprecated

Joshua Lambert requested to merge jl-remove-embed-sign into master

What does this MR do and why?

The embed_sign flag has been deprecated in ruby_saml: https://github.com/onelogin/ruby-saml/pull/610. We should no longer be setting it explicitly, as it is likely to go away. In addition, we have seen problems with this configuration, as it seems to try to use embed_sign in conjunction with HTTP-Redirect bindings. (At least that is the behavior we were seeing with this default settings in this code block)

We should move away from this, and if needed use the newer settings.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports