Skip to content

Refactor hook log index view

Anton Smith requested to merge webhook-logs-refactor-partials into master

What does this MR do and why?

In preparation for Add "Recent Deliveries" to group webhooks UI and as discussed in this thread, this MR refactors the admin/project/integrations hook log index view to use a shared HAML view instead. The project hook log index view has been moved and repurposed as a shared view, and the admin hook log index view has been deleted. The integration hook log index was originally using the project hook log index.

Since all index views were somewhat identical, there are no visual changes in the frontend.

Screenshots or screen recordings

Project Hooks System Hooks Service Hooks
Screen_Shot_2022-08-01_at_12.30.58_PM Screen_Shot_2022-08-01_at_4.51.39_PM Screen_Shot_2022-08-02_at_1.30.09_PM

How to set up and validate locally

  1. Switch to the feature branch
  2. Create a project hook and an admin hook, and test both.
  3. Confirm that you can view the hook logs page when you edit both the project and admin hooks pages.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Anton Smith

Merge request reports