Skip to content

Idempotent build hooks worker

Alex Kalderimis requested to merge ajk-idempotent-build-hooks into master

What does this MR do and why?

This MR has the payload for job hooks computed inline.

Prior to this change, the payload was computed in the sidekiq worker which may have different data due to replication lag.

This change computes the payload when we enqueue the job, skipping the job hooks worker.

The downside here is that we are passing the payload to sidekiq, which means in Redis, and increases the size of the Redis values stored on the queue.

See: #366755 (closed)

How to set up and validate locally

This should not change the job hooks that we send - just make them more reliable.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Kalderimis

Merge request reports

Loading