Skip to content

Update dialogue according to the new endpoint

Nataliia Radina requested to merge 368380-delete-rule-modal into master

What does this MR do and why?

This is a follow-up MR for another MR For the 368380 the endpoints were updated, but I missed that in the delete dialogue approvers should be also updated to eligibleApprovers

Screenshots or screen recordings

Before After
Screenshot_2022-08-04_at_00.32.59 Screenshot_2022-08-04_at_00.33.21

How to set up and validate locally

  1. Make sure you have ee features enabled

  2. Select any project

  3. Go to Settings => General

  4. Expand the MERGE REQUESTS APPROVALS section

  5. First create and then try to delete approvale rule

  6. Check that displaying, creating, editing and deleting rules works same as usual

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #368380 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading