Skip to content

Fix group mr approval selective codeowner removals

Lee Tickett requested to merge 344632-fix-group-selective-codeowner-setting into master

What does this MR do and why?

I have introduced a bug in !90578 (merged)

When reset approvals on push is NOT set at group level, the radio is left blank (it should show as "keep all approvals"):

image

This is because, the selective code owner removals value is incorrectly being returned as true from the API.

Validation

  1. Checkout master, view group settings
  2. Set merge request approval setting to "keep approvals"
  3. You will see the radio resets to blank
  4. Set the value to "remove all approvals"
  5. You will see the radio correctly remains set
  6. Checkout this branch
  7. Repeat above

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344632 (closed)

Edited by Max Woolf

Merge request reports

Loading