Skip to content

Fix scoped labels to render tooltips correctly

Dheeraj Joshi requested to merge djadmin-fix-scoped-label-tooltip into master

Fixes #263773 (closed)

What does this MR do and why?

It was found that DOMPurify (which is used by v-safe-html) strips off attribute completely if it contains any self-closing tag. The scoped label tooltip template uses <br /> which gets removed when passed through v-safe-html. Hence the tooltips are not getting rendered correctly, as shown at #263773 (closed).

This MR replaces <br /> with <br> which is a valid HTML element - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br which should fix the underline issue.

Screenshots or screen recordings

scoped_label

How to set up and validate locally

  1. Create a scoped label with some description.
  2. Apply this label to any MR / Issue.
  3. The applied label should render the tooltip now.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dheeraj Joshi

Merge request reports

Loading