Skip to content

Cleanup feature flags and env vars for cross_database_modification

What does this MR do and why?

This MR is cleaning up feature flags and env vars that have been enabled for some time. These feature flags correspond to our "cross-database modification" detection and we want this enabled by default.

  1. We enabled track_gitlab_schema_in_current_transaction on 2022-02-01. See #349944 (comment 827636394)
  2. We enabled ENABLE_CROSS_DATABASE_MODIFICATION_DETECTION in production on 2021-12-08. See gitlab-com/gl-infra/k8s-workloads/gitlab-com!1390 (merged)

After we merge this and it's deployed to production we can remove ENABLE_CROSS_DATABASE_MODIFICATION_DETECTION from all our production configurations. I've created a separate issue for that #370429 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #351845 (closed)

Edited by Dylan Griffith

Merge request reports

Loading