Skip to content

Account for E2E quarantine diff to start from a new line

Nailia Iskhakova (OOO) requested to merge qe-run-qa-check-fix into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Update run_qa_check tool to account for cases when E2E spec is being quarantined by adding quarantine: metadata to a new line. Without this change check only works for specs with , quarantine: cases.

Example of cases when quarantine: is added to a new line: web_terminal_spec.rb#L9, create_project_with_auto_devops_spec.rb#L6, !95053 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Example of both cases in diff:

Click to expand Screenshot_2022-08-11_at_17.56.09

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Generate or download git diff (example)

  2. Run run_qa_check and ensure it exits with error code 2

     tooling/bin/qa/run_qa_check tmp/diffs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading