Skip to content

Disable Rugged auto-detection by default

Stan Hu requested to merge sh-disable-rugged-auto-detect into master

What does this MR do and why?

Now that Praefect manages paths by default via gitaly!4809 (merged), the use of direct disk access via Rugged doesn't work if Praefect is use, which is the case for most GDK users.

We already disable Rugged when Puma is in use. This merge request now disables the disk auto-detection by default with the skip_rugged_auto_detect feature flag. Rugged will still be enabled if the Rugged-specific feature flags are enabled.

This would avoid issues when users migrate over to Gitaly on a separate node but keep a stale copy of the .gitaly-metadata files: #368545 (closed)

Relates to gitlab-development-kit#1556 (closed)

Relates to gitaly#2263 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports