Skip to content

Improve `user_email_help_text`: do not split sentence for i18n

Zhiyuan Lu requested to merge gitlab-jh/jh-team/gitlab:370555-improve-user_email_help_text into master

What does this MR do and why?

No longer split sentences for i18n in user_email_help_text. So that the translator has full context, and also have ability to reorder the subject order.

Screenshots or screen recordings

Before After

There seems to be no difference Before and After, but Before is spliced based on multiple copy fragments, and After directly uses one copy.

In this case, the change brought a significant benefit: the translator was free to use Chinese periods 。 instead of English periods .

How to set up and validate locally

Visit path: http://localhost:3000/-/profile

cc JH @prajnamas @icbd

issue: #370555

Edited by Zhiyuan Lu

Merge request reports