Skip to content

Make report_jemalloc_stats :ops FF default enabled

Aleksei Lipniagov requested to merge 367845-make-jemalloc-reports-ff-default-enabled into master

What does this MR do and why?

We enabled this feature flag globally: #367845 (closed)

It is enabled right now: https://gitlab.slack.com/archives/CB2S7NNDP/p1660562400540469

Screenshot_2022-08-15_at_13.20.29

We haven't experienced any issues with that, aside from the confusion with Sidekiq node execution timings, which we'll address separately.
So the next step would be to make it default_enabled=true.

It will remain :ops type, so we will be able to disable it quickly on gprd if needed.
It won't affect self-managed: GITLAB_DIAGNOSTIC_REPORTS_ENABLED should be set true to even start collecting the reports and hitting the FF check.

How to set up and validate locally

In this case, we could rely on CI.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #367845 (closed)

Edited by Aleksei Lipniagov

Merge request reports