Skip to content

Allow some lib spec to use `fast_spec_helper`

Peter Leitzen requested to merge pl-fast-specs-lib into master

What does this MR do and why?

Allow some lib specs (spec/lib + ee/spec/lib) to use fast_spec_helper.

The script to check this was:

for file in "$@"
do
  echo "Trying $file"
  sed -i "s/^require .spec_helper./require 'fast_spec_helper'/" "$file"
  bin/rspec --order defined --format progress "$file" || git co "$file"
done

Note, some order dependent specs were excluded.

Refs !89633 (closed)

Why?

Using fast_spec_helper also helps to uncover spec failures due to order dependency because it reduces the runtime and eases the use of RSpec bisect.

How to set up and validate locally

Verified via:

files=$(git diff HEAD~ --name-only | xargs)
bin/rspec --order defined --format progress $2014211 

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports

Loading