Skip to content

Change the way autoclosing issues is checked

Heinrich Lee Yu requested to merge 240922-fix-closing-issues-setting into master

What does this MR do and why?

This MR changes the behavior of the "Auto-close referenced issues on default branch" setting.

Previously, we were checking the setting of the project of the commit / MR. This changes this to check the setting of the project of the issue being referenced.

More info about the change in #240922 (closed)

How to set up and validate locally

  1. Create Project A with autoclose issues disabled
  2. Create Project B with autoclose issues enabled
  3. Push a commit to Project B's default branch with a commit message closing an issue of Project A. The issue should not be closed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports