Skip to content

Use Correct Storage Enforcement in Namespace::Storage::Notification

Jason Goodman requested to merge project-repo-limit-banner-paid-nss-enabled-free into master

What does this MR do and why?

Current Behavior

When namespace storage limits are enabled for free namespaces, paid namespaces that have exceeded their project repository excess storage limit receive an incorrect notification banner. This is because during the rollout, we will enable the <code data-sourcepos="5:245-5:268">:namespace_storage_limit</code> feature flag globally.

After this MR

When namespace storage limits are enabled for free namespaces, paid namespaces that have exceeded their project repository excess storage limit will receive the correct notification banner.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/369153

Screenshots

Current Behavior

Namespace storage limits are enabled for free plans, but not for paid plans.

This project in a paid plan (ultimate) has exceeded it's project repository size limit. The namespace is shown the banner for namespace storage limits, and the banner has erroneous data:

Screen_Shot_2022-10-07_at_1.58.33_PM

After this MR

The namespace is shown the correct project repository size limits banner:

Screen_Shot_2022-08-19_at_3.49.23_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jason Goodman

Merge request reports