Skip to content

Codequality tabs migration

Jannik Lehmann requested to merge jnnkl-codequality-tabs-migration into master

What does this MR do and why?

This MR is meant to solve: #360797 (closed)

It migrates the codequality pipeline tab corresponding to the larger refactoring from HAML to vue.

Migrating the Codequality tabs is slightly different to other tabs on the pipeline-tabs component since it currently has two versions (one using fetch the other one using GraphQl) implemented and is toggle via the graphql_code_quality_full_report Flag. More about this below.

Screenshots or screen recordings

Goal of this MR is that the codequality tabs is displaying correctly no matter which state graphql_code_quality_full_report or pipeline_tabs_vue are in

graphql_code_quality_full_report pipeline_tabs_vue Screenshot
true true Screenshot_2022-08-23_at_16.22.46
false false Screenshot_2022-08-23_at_16.18.22
true false Screenshot_2022-08-23_at_16.26.02
false true Screenshot_2022-08-23_at_16.20.12

How to set up and validate locally

  1. Create a Project with Codequality enabled (or clone https://gitlab.com/jannik_lehmann/code-quality-test)
  2. Start a pipeline
  3. Go to http://GDKPATH/USER/PROJECT/-/pipelines/PIPELINEID/codequality_report to see the tabs in action.
  4. play around with the graphql_code_quality_full_report & pipeline_tabs_vue according to the truth table above

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading