Skip to content

Update tabs line-height to match Pajamas

Miguel Rincon requested to merge mrincon-update-tabs-height-css-units into master

What does this MR do and why?

This MR comes from a conversation we have at gitlab-ui!2990 (comment 1076108753), where improving the position of our badges has an impact on some of our tabs.

This fix updates the line-height and padding values in tabs so they match Pajamas tabs, such as the ones created by the <gl-tab> gitlab-ui component.

Changelog: changed

Note: Global .nav-links are impacted by this change, so changes are small on each page, but numerous pages are impacted.

Screenshots or screen recordings

Tip: Open both images in new browser tabs and switch between them to compare:

Type any search in the upper right search bar: "Search GitLab"

before after
before after

Visit Admin -> Projects (/admin/projects)

before after
before-1 after-1

Visit Menu -> Your Projects (/dashboard/projects)

before after
before-3 after-3

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports

Loading