Skip to content

Dismiss Service for Security Finding

Jonathan Schafer requested to merge 367402-security-finding-dismiss-service into master

What does this MR do and why?

This MR creates a dismiss service for a security finding, similar to the dismiss service for a vulnerability finding. It needs its own service, however, as the 2 types of findings have some different attributes and behaviors.

The idea here was to mimic https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/vulnerabilities/finding_dismiss_service.rb and https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/vulnerabilities/dismiss_service.rb. Once the dust settles on the feedback removal epic, we can create a base class to simplify the code for these 3 similar classes. My plan is to do minimal work to get this service up for the GraphQL mutation, since it's going to be heavily modified with the feedback removal anyway.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #367402 (closed)

Edited by Jonathan Schafer

Merge request reports

Loading