Skip to content

Fix options of QA `ContextSelector`

Song Huang requested to merge gitlab-jh/jh-team/gitlab:bugfix/qa-context-matches into master

What does this MR do and why?

Solves this issue

  1. Move opts.merge!(option) outside of options.each block.
  2. Added test cases to ensure options domain and tld can be used independently.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

/cc @daveliu

Edited by Song Huang

Merge request reports