Skip to content

Revert "Add file format adapter for zip"

Brian Williams requested to merge bwill/remove-zip-adapter into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Related to: #371778 (closed)

In !94107 (merged) we added a streaming adapter for Zip so that we could iterate through zip archives using artifact.each_blob. We tested this adapter using zip files produced by the zip command line utility, but neglected to test it with archives produced by GitLab Runner. When iterating further, we found that it doesn't actually work as zip archives produced by Go's archive/zip do not support streaming reads (https://github.com/golang/go/issues/23301#issuecomment-363240781). For the particular implementation that we were working on, we decided to switch the artifacts to use gzip instead (!96285 (merged)). Since no other implementations use this adapter, and since it doesn't work, this MR removes it by reverting !94107 (merged).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brian Williams

Merge request reports