Simplify response type of Gitaly's FindLocalBranches
What does this MR do and why?
Probably for legacy reasons, the FindLocalBranches RPC in Gitaly does not use the Branch protobuf message in its response. This adds maintenance overhead.
It would be better if we just used the Branch message in the response. When we change this we need to do so in a backwards-compatible manner, i.e. keep sending the old fields, until 1 gitlab release after this is fixed.
The corresponding changes have been made in Gitaly under the feature flag gitaly_simplify_find_local_branches_response, The same feature flag will be used in this MR to tie together the Ruby code for the same.
In the next release we'll remove the old code and deprecate the old fields.
Gitaly MR for protobuf changes: gitaly!4842 (merged) Gitaly MR for feature changes: gitaly!4850 (merged)
Relates to gitaly#1294 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
No visual changes are made here.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable the feature flag
Feature.enable(:gitaly_simplify_find_local_branches_response) - Go to the branches route for any repo e.g.: http://localhost:3000/gitlab-org/gitlab-shell/-/
- Ensure branches are displayed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #12944 (closed)