VSA correctly display `0` and `no value` days for total time chart
What does this MR do and why?
This MR fixes inconsistencies with how we render the total / stage time charts in value stream analytics. The data set from the api currently only returns data points for days where we have a value calculated. This has caused confusion since the rendered chart does not accurately reflect the date range selected.
This MR:
- Ensures the chart contains a data point for every date in the date range
- Renders a dotted line for dates that have a
null
value - Correctly render dates that have a value, but the value is
0
Screenshots or screen recordings
Before | After |
---|---|
Tooltip states (After)
With null data |
With 0 value |
With a mixture |
---|---|---|
How to set up and validate locally
Creating a group level value stream
- Ensure you have an EE license, or stub the
cycle_analytics_for_groups
license feature to true - Create a group
- Create a project within a group (I recommend creating a project from a template such as the rails template)
-
Create a custom value stream for the new group you created
Note: The first time you create a value stream in a group, a data aggregation needs to run, ingdk
this is usually ~10mins, proceed to make a coffee in the meantime, relax☕ 😎
Seeding data
-
Seed some test VSA data
$ VSA_SEED_PROJECT_ID=<project-id> VSA_ISSUE_COUNT=10 SEED_VSA=true FILTER=cycle_analytics rake db:seed_fu
-
Navigate to the group value stream for the group you created
-
Navigate through the different stages in the value stream and hover over the stage time / total time chart to see the popover
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #368304 (closed)
Edited by Ezekiel Kigbo