Skip to content

Allow job token configuration while disabled

Laurent Deketelaere requested to merge ali_o_kan/gitlab:340494-allow-job-token-scope-to-be-configured-while-disabled into master

What does this MR do and why?

Allow the job token scope to be configured (e.g. projects to be added/removed) while the setting is disabled.

  • backend : remove guards in JobTokenScopeResolver and EditScopeValidations
  • frontend : remove guard to display token-section all the time in token_access.vue component
  • update tests

Screenshots or screen recordings

Before:

image

After:

image

How to set up and validate locally

  1. On the top bar, select Menu > Projects and find your project.
  2. On the left sidebar, select Settings > CI/CD.
  3. Expand Token Access.
  4. Toggle Limit CI_JOB_TOKEN access to disabled.
  5. Add existing projects to the token’s access scope. The user adding a project must have the Maintainer role in both projects.
  6. Remove existing projects to the token’s access scope. The user adding a project must have the Maintainer role in both projects.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #340494 (closed)

Edited by Laurent Deketelaere

Merge request reports