Skip to content

Use Merged Result commit SHA for Review Apps and package-and-qa

Nao Hashizume requested to merge nh-use-commit-sha into master

What does this MR do and why?

This MR switches the ref for Review Apps and package-and-qa in the merged results pipeline to be CI_COMMIT_SHA from CI_MERGE_REQUEST_SOURCE_BRANCH_SHA.

This change helps us reduce the amount of "rebase of the MR to fix" issues when the latest code is out of sync with deployed Review Apps, and improve Time to First Failure and merge request pipeline stability.

Closes gitlab-org/quality/engineering-productivity/team#52 (closed)

Testing

See the example https://gitlab.com/gitlab-org/gitlab/-/pipelines/629160845 (package-and-qa) and https://gitlab.com/gitlab-org/gitlab/-/pipelines/629160850 (Review App) pipelines when using CI_COMMIT_SHA instead of CI_MERGE_REQUEST_SOURCE_BRANCH_SHA.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andrejs Cunskis

Merge request reports