Move updated thread control out of sidebar feature flag
What does this MR do and why?
- Moves the thread control design updates out of the feature flag
- Fixes various spacing bugs
- Adds expand/collapse option when all threads are resolved
Screenshots or screen recordings
Feature flag on | Feature flag off | |
---|---|---|
Unresolved threads | ||
All resolved |
How to set up and validate locally
- Enable
:moved_mr_sidebar
- View MR with unresolved threads (ellipsis dropdown should have options to expand/collapse threads and create issue to resolve all threads)
- View MR with threads all resolved (ellipsis dropdown should have only option to expand/collapse threads
- Disable
:moved_mr_sidebar
- Follow steps 2 and 3; design and experience should be the same
Out of scope Since having a dropdown with only one item isn't ideal, perhaps use expand button icon instead of dropdown
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to ✨ Beautifying our UI: Create:Code Review ✨ (#364574 - closed)
Edited by Annabel Dunstone Gray