Skip to content

Add curly brackets to fix the matcher in ruby 3

Roy Zwambag requested to merge 372415-fix-cache-service-spec-ruby3 into master

What does this MR do and why?

https://gitlab.com/gitlab-org/gitlab/-/jobs/2967128654

This spec fails in Ruby 3 due to the way rspec-mocks handles hash vs kwargs matching.

Similar to !86157 (merged), see this MR for more context

How to set up and validate locally

Run the spec in both Ruby 2.7.5 (regular way) and Ruby 3.0.4, both should pass

You can run specs in ruby 3 by:

  • Executing asdf local ruby 3.0.4
  • Run the spec

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #372415 (closed)

Edited by Roy Zwambag

Merge request reports