Skip to content

Update third party login styles

Jannik Lehmann requested to merge jnnkl-third-party-login-styles into master

What does this MR do and why?

This MR is meant to solve: #372787 (closed) It solves an Issue with alignment of the 3rd party providers of the redesigned sign-in page.

Screenshots or screen recordings

before after
Screenshot_2022-09-07_at_11.00.46 Screenshot_2022-09-07_at_10.59.01

How to set up and validate locally

This is unfortunately a little bit of a pain to reproduce, since I couldn't find a way to configure multiple 3rd party providers on a GDK.

I worked with the following hack, which should be good enough for demo purposes

  1. enable restyle_login_page
  2. go to login page
  3. execute the script below
let container = document.querySelector('.omniauth-container');
let form = container.querySelector('form');
let numberOfClones = 6;
for (let i = 0; i < numberOfClones; i++) {
  let clone = form.cloneNode(true);
  form.parentElement.appendChild(clone);
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading