Skip to content

Exclude TOOL_VENDOR from using ToolFilter

What does this MR do and why?

In the initial Epic (&8407 (closed)), the intention was to migrate all 3 views to populate its dropdown data using GraphQL. Thus far, we have achieved that. Unfortunately, the project view in production supports multiple vendors display (group and instance do not). At this moment the frontend is unable to build out that feature, please see this discussion > #368269 (comment 1033162765). So as not to delay the roll-out of this feature, we will solve this iteratively 🐾 We will only migrate the Group and Instance view to use the new GraphQL populated component. The project view will be excluded and use the existing ScannerFilter.vue component.

In this MR, the project view is excluded from using the ToolFilter.vue component and will return to using the original ScannerFilter.vue component.

Screenshots or screen recordings

Project Group Instance
2022-09-07_at_9.59_PM 2022-09-07_at_9.59_PM 2022-09-07_at_10.00_PM
ToolFilter.vue
ScannerFilter.vue
ToolFilter.vue ToolFilter.vue

How to set up and validate locally

  1. Enable the FF echo "Feature.enable(:refactor_vulnerability_tool_filter)" | rails c
  2. Project view (Project > Security & Compliance > Vulnerability report) - uses ScannerFilter.vue
  3. Group view (Group > Security & Compliance > Vulnerability report) -- uses ToolFilter.vue
  4. Instance view (Menu > Security > Vulnerability Report) -- uses ToolFilter.vue

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Samantha Ming

Merge request reports

Loading