Skip to content

Add router to group overview tabs

Peter Hegman requested to merge 23466-convert-groups-overview-tabs-to-vue into master

What does this MR do and why?

Related to #23466 (closed)

Follow-up to !95850 (merged)

In !95850 (merged) we introduced the group_overview_tabs_vue feature flag to start converting the group overview tabs from HAML/jQuery/Vue to fully Vue. This MR builds on the previous MR and adds Vue router so the URL changes when you change tabs.

Future MRs

  1. Add search and sort functionality
  2. Default enable feature flag

Screenshots or screen recordings

Before After
Screen_Recording_2022-09-07_at_2.55.53_PM Screen_Recording_2022-09-07_at_2.55.08_PM

How to set up and validate locally

  1. Enable group_overview_tabs_vue feature flag
    • bin/rails console
    • Feature.enable(:group_overview_tabs_vue)
  2. Go to a group overview. e.g http://gdk.test:3000/flightjs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports

Loading