Skip to content

Remove max-width from MR widget loading state

What does this MR do and why?

Fixes First widget in MR widgets block has an alignme... (#372976 - closed)

Also fixes centered report widgets bug.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

Apply patch:

Preview.patch
Index: app/assets/javascripts/vue_merge_request_widget/components/extensions/index.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/extensions/index.js b/app/assets/javascripts/vue_merge_request_widget/components/extensions/index.js
--- a/app/assets/javascripts/vue_merge_request_widget/components/extensions/index.js	(revision 7acc9ba72dd41ca10b77cf8c215fd59a1f247134)
+++ b/app/assets/javascripts/vue_merge_request_widget/components/extensions/index.js	(date 1662593377670)
@@ -1,4 +1,5 @@
 import Vue from 'vue';
+import code_quality from '~/vue_merge_request_widget/extensions/code_quality';
 import ExtensionBase from './base.vue';
 
 // Holds all the currently registered extensions
@@ -49,3 +50,5 @@
     },
   });
 };
+
+[code_quality].forEach(registerExtension);
Index: app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js b/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js
--- a/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js	(revision 7acc9ba72dd41ca10b77cf8c215fd59a1f247134)
+++ b/app/assets/javascripts/vue_merge_request_widget/extensions/code_quality/index.js	(date 1662593377663)
@@ -61,6 +61,7 @@
   },
   methods: {
     fetchCollapsedData() {
+      return new Promise();
       return Promise.all([this.fetchReport(this.codeQuality)]).then((values) => {
         return {
           resolvedErrors: parseCodeclimateMetrics(
  1. Open any merge request

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stanislav Lashmanov

Merge request reports

Loading