Skip to content

Add codeowners for doc image files and rule maintainers

Marcel Amirault requested to merge docs-codeowners-for-images into master

What does this MR do and why?

While reviewing !97298 (merged), I noticed that it needed a code maintainer approval, despite being docs-only. I realized that .png images are not taken into account in the codeowners, so any MR updating a docs image falls back on the default * approval rule (needing a mandatory code maintainer approval). TWs are not included as code maintainers, so they cannot approve or merge docs MRs with images right now.

This MR adds *.png to the rules for docs files. Adding /doc/*.png is not needed because we do not want to put any images in the root of the docs directory tree.

Additionally, the TW team's codeowners entries change from time to time when we reassign TWs to different groups, so we should add Technical Writing Leadership team members to the list of users who can approve changes to the file. Discussed here: !97072 (comment 1090253124)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marcel Amirault

Merge request reports

Loading