Skip to content

Project setting for suggested reviewers

Alper Akgun requested to merge 373013-frontend-enabling-suggested-reviewers into master

What does this MR do and why?

Project setting for Suggested Reviewers

Related to #373013 (closed)

We can use HAML and view components for little frontend functionality per https://docs.gitlab.com/ee/development/fe_guide/haml.html#haml-and-our-pajamas-design-system

Migration output

$ bin/rails db:migrate:up:main VERSION=20220918124223
main: == 20220918124223 AddEnableSuggestedReviewersToProjectSettings: migrating =====
main: -- add_column(:project_settings, :suggested_reviewers_enabled, :boolean, {:default=>false, :null=>false})
main:    -> 0.0138s
main: == 20220918124223 AddEnableSuggestedReviewersToProjectSettings: migrated (0.0143s) 

$ bin/rails db:migrate:down:main VERSION=20220918124223
main: == 20220918124223 AddEnableSuggestedReviewersToProjectSettings: reverting =====
main: -- remove_column(:project_settings, :suggested_reviewers_enabled, :boolean, {:default=>false, :null=>false})
main:    -> 0.0018s
main: == 20220918124223 AddEnableSuggestedReviewersToProjectSettings: reverted (0.0034s)

Screenshots or screen recordings

image

How to set up and validate locally

  1. Ensure a SaaS (Gitlab.com) environment
    1. One way of doing this is to add a env.runit file to the root GDK folder with the following snippet export GITLAB_SIMULATE_SAAS=1
  2. Set ultimate license on a group http://gdk.test:3000/admin/groups
  3. Create a project in there
  4. Enable the feature flag on rails console bin/rails c => Feature.enable(:suggested_reviewers, project)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alper Akgun

Merge request reports