Skip to content

Resetting form doesn't affect submit button

Eduardo Sanz García requested to merge eduardosanz/fix-submit-button into master

What does this MR do and why?

Fix regression from !96379 (merged).

After a successful creation of a personal access token the text of the submit button was removed.

We have change the logic to be more selective. In addition, we don't add checked attributes to text input fields and, the other way around, adding value attributes to checkbox input fields

Closes #373228 (closed)

Screenshots or screen recordings

Before

Personal_Access_Tokens___User_Settings___GitLab

After

Screen_Recording_2022-09-09_at_11.57.55

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to Profile > Personal access tokens
  2. Create access token
  3. Track how the values are reset except the datepicker and the submit button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports